Aerodrome OETH AMO #2019
Closed
Aerodrome OETH AMO #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Tooling for Base network * Fix scripts * Add empty migrations file * Fix failing fork tests
sparrowDom
reviewed
May 17, 2024
| * @param asset address of the asset | ||
| * @return uint256 unit price for 1 asset unit, in 18 decimal fixed | ||
| */ | ||
| function price(address asset) |
There was a problem hiding this comment.
this function is still identical to the one in OETHOracleRouter. You can create a OETHOracleRouterBase and implement the price function in it. And then have OETHOracleRouter and BaseOETHOracleRouter inherit from it
There was a problem hiding this comment.
Refactored here: 826361f
* feat: oethcore deployment * chore: fix deployment setup * chore: update global hook * config: update defi.yml * config: add base fork tests to defi.yml * Fix order of comparison * Minor tweaks * Fund correct deployer on fork * fix: tests * chore: fix tests * chore: remove stack trace flag * chore: fix typo * chore: fix test * fix: base fork test fixture * chore: rename deployment file * feat: OETHBase Vault base fork tests * fix: unit tests * feat: add more fork tests * feat: refactor deploy actions, fixture and fork test * chore: minor optimization * refactor: fix deploy actions and fixtures * refactor: fork tests * refactor: harvester contracts * refactor: tests and deploy action * chore: more refactoring * Update deploy scripts to use Guardian address (#2075) * wip * refactor: update deploy scripts to use guardian * chore: rename AeroHarvester -> OETHBaseHarvester * refactor: abstract oracle contract * chore: fmt * refactor: base harvester aerodrome route --------- Co-authored-by: Domen Grabec <[email protected]> Co-authored-by: Shahul Hameed <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
- Coverage 60.34% 56.22% -4.13%
==========================================
Files 59 64 +5
Lines 3006 3262 +256
Branches 775 637 -138
==========================================
+ Hits 1814 1834 +20
- Misses 1189 1425 +236
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Aerodrome OETH AMO
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist:
Notion resources: