Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/oeth withdrawal #149

Merged
merged 42 commits into from
Aug 12, 2024
Merged

Feat/oeth withdrawal #149

merged 42 commits into from
Aug 12, 2024

Conversation

toniocodo
Copy link
Collaborator

@toniocodo toniocodo commented Jul 11, 2024

This PR brings OETH withdrawals support with redemption queue and ARM route

  • ❌ Fill ARM address in `libs/shared/contracts/src/contracts.ts
    • Not available at time of merge so I've set 'comingSoon' to true and marked the route unavailable.
  • Verify ARM route estimateGas and swap functions in libs/shared/routes/src/oeth/redeemArmOeth.ts, contract and abis were not final at the time of the PR
    • Updated ABI and verified functions.

@toniocodo toniocodo changed the base branch from main to next August 2, 2024 19:05
- mark ARM route unavailable and coming soon
- updated OETHVault abi
@apexearth apexearth marked this pull request as ready for review August 12, 2024 15:37
- call requestWithdrawal instead of redeem
- I see there is `redeemVaultAsyncOeth.ts` but it doesn't look complete, so changing this route seems more appropriate.
@apexearth apexearth merged commit 8756e3e into next Aug 12, 2024
@apexearth apexearth deleted the feat/oeth-withdrawal branch August 12, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants