Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIL - ignore include statements, in-line loop comments #209

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

rlaj
Copy link
Member

@rlaj rlaj commented Oct 4, 2024

This PR includes two updates:

  1. New function to parse STIL into AST that ignores include statements

  2. Loop comments - comments on loop line are now in node that is child of loop node

EXAMPLE STIL:

  Loop 5    { V { group1=0p11T;  } } // vecLine:6, testCycle:6
  // COMMENT
  Loop 3    { V { group1=0p10t;  } } // vecLine:7, testCycle:11
  // COMMENT

PREVIOUS:

        Loop(5)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p11T")
        Comment("// vecLine:6, testCycle:6")
        Comment("// COMMENT")
        Loop(3)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p10t")
        Comment("// vecLine:7, testCycle:11")
        Comment("// COMMENT")

UPDATED:

        Loop(5)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p11T")
            Comment("// vecLine:6, testCycle:6")
        Comment("// COMMENT")
        Loop(3)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p10t")
            Comment("// vecLine:7, testCycle:11")
        Comment("// COMMENT")

@rlaj rlaj requested review from ginty, priyavadan and coreyeng October 4, 2024 13:30
Copy link
Member

@priyavadan priyavadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the updates!

Copy link
Member

@ginty ginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlaj rlaj merged commit f0951a5 into master Oct 7, 2024
12 checks passed
@rlaj rlaj deleted the stil_updates branch October 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants