-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCi to Github actions migration #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souzamari
force-pushed
the
ci/add-ci-workflow
branch
2 times, most recently
from
October 22, 2024 19:51
7ffc38f
to
6ea6a4c
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
October 22, 2024 19:54
6ea6a4c
to
fe51217
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
October 22, 2024 20:38
ab15969
to
00d8f27
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
October 23, 2024 13:53
fb6cd2e
to
701968e
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
October 23, 2024 14:01
701968e
to
f4098d3
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
3 times, most recently
from
October 23, 2024 19:11
97aaecd
to
0225109
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
October 23, 2024 19:29
0225109
to
92944e9
Compare
neat 👌 |
souzamari
force-pushed
the
ci/add-ci-workflow
branch
2 times, most recently
from
October 24, 2024 15:14
752c1c1
to
9c86345
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
October 24, 2024 15:22
9c86345
to
a7fc6f6
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
2 times, most recently
from
October 24, 2024 17:09
7cd130d
to
c861068
Compare
dany-pellerin
force-pushed
the
ci/add-ci-workflow
branch
8 times, most recently
from
November 14, 2024 16:02
e27fb2a
to
d98ab00
Compare
dany-pellerin
force-pushed
the
ci/add-ci-workflow
branch
from
November 14, 2024 19:15
d98ab00
to
a2537f0
Compare
dany-pellerin
changed the title
CI: Initial gha workflow - run tests
CircleCi to Github actions migration
Nov 14, 2024
souzamari
commented
Nov 15, 2024
souzamari
force-pushed
the
ci/add-ci-workflow
branch
4 times, most recently
from
November 28, 2024 20:28
19fac5b
to
31c9bbd
Compare
souzamari
force-pushed
the
ci/add-ci-workflow
branch
from
November 28, 2024 20:31
31c9bbd
to
3b77249
Compare
dany-pellerin
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dany-pellerin
force-pushed
the
ci/add-ci-workflow
branch
from
December 3, 2024 18:34
2cd6b25
to
49b4db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates existing CircleCI workflow of
optable-ios-sdk
to GitHub actionsThe runners needed to be updated and we can't use the same runner for setup and for build:
macos-13
otherwise the ruby version is unavailable. If the dependencies are cached it won't fail with macos-14, but we should not rely on the cache.macos-14
, otherwise the build will failThe CircleCI workflow ran in 2 different cases:
tests
,build-demo-swift
andbuild-demo-objc:
jobs for the standard buildtests
,build-demo-swift
,build-demo-objc:
andsuccess-slack-notify
Slack notifications will be added back eventually when a reusable action is created, for now we're ignoring it as it's not a critical part of the build process.
The workflow is essentially the same for pull-requests and tagging, for the sake of simplicity we are using the same workflow in the github action, eventually it could be split in 2. Contrary to the web-sdk, the publishing step needs to be done manually and the process is described in the
releasing.md
file.The only artifact that was published with CircleCi was the build log
This github action creates the following artifacts:
Slack integration notification: