refactor(robot-server): Delete obsolete workarounds for discriminated unions in Pydantic v1 #17145
+17
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Now that we're on Pydantic v2, we can delete these old workarounds for pydantic/pydantic#3782. Closes EXEC-1065.
Test Plan and Hands on Testing
commandType
, not all possible commands. You'll know if this isn't working properly because the error message will be the length of the novel if you forget a param.Review requests
None.
Risk assessment
Low if the manual test plan is done.