Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(robot-server): Delete obsolete workarounds for discriminated unions in Pydantic v1 #17145

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Dec 18, 2024

Overview

Now that we're on Pydantic v2, we can delete these old workarounds for pydantic/pydantic#3782. Closes EXEC-1065.

Test Plan and Hands on Testing

  • Run a dev server, try sending a command to these endpoints, and make sure the errors reflect that the union discriminator is being used. In other words, Pydantic should only try parsing the input as the command you specified by commandType, not all possible commands. You'll know if this isn't working properly because the error message will be the length of the novel if you forget a param.

Review requests

None.

Risk assessment

Low if the manual test plan is done.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner December 18, 2024 22:52
@SyntaxColoring SyntaxColoring changed the title refactor(robot-server): Delete obsolete discriminated union workarounds for Pydantic v1 refactor(robot-server): Delete obsolete workarounds for discriminated unions in Pydantic v1 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant