Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api, robot-server): redirect router level calls to PE and protocol_runners via run orchestrator #15257
refactor(api, robot-server): redirect router level calls to PE and protocol_runners via run orchestrator #15257
Changes from 37 commits
667147d
47e5f5d
e88982c
34b4391
7bd9f5f
7b29b9a
29813d8
c8f1f4b
9d9979f
13a0cb8
43d82e8
31e0051
9531aa7
8e06362
967f78e
2e00e7d
4b27221
bc8237a
bcdfcea
a079763
98bc42e
9b9f11f
2ffc0a8
aa156bb
c598bfa
9e8775a
3fb5cba
a5ddce7
815c7d9
83e484b
1602623
c18bf98
04c0e1d
20202f1
8dcc13f
2ef261c
42dbedd
ee5e5a3
836c3f6
77bf864
a1121d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks a little questionable that
self._setup_runner.prepare()
andself._fixit_runner.prepare()
are called for live HTTP runs (because that's the only thing callingRunOrchestrator.prepare()
), and are not called for JSON or Python protocols. In all cases, the setup runner and fixit runner behave the same, right? So shouldn't they consistently always be.prepare()
'd or never be.prepare()
'd?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I will fix it.