fix(react-api-client): filter out unknown modules in the /modules endpoint. #15256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The desktop app is blocked when it gets an unknown module in the
GET /modules
response, which happens when the user clicks on theDevices
side panel in the desktop app. Since we query modules for all discovered robots, it can be confusing to know which robot the unknown module is connected to. There will sometimes be a lag between developing and supporting new modules in the desktop app. So instead of blocking the desktop app, we should filter out unknown modules in theGET /response
.Closes: RABR-316
Test Plan
Changelog
select
option of reactUseQuery
to filter out unknown modulesReview requests
Risk assessment
low