Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): fix type specification for add_parameters() #15255

Merged
merged 1 commit into from
May 23, 2024

Conversation

ecormany
Copy link
Contributor

Overview

I got the type specification for the object of add_parameters() wrong.

Test Plan

Simulated a protocol that uses the def add_parameters(… line verbatim on 7.3.0-b1.

Changelog

1-line diff

Risk assessment

none

@ecormany ecormany requested a review from a team as a code owner May 23, 2024 17:37
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@ecormany ecormany merged commit b57d92b into docs_release-2.18 May 23, 2024
26 checks passed
@ecormany ecormany deleted the docs-fix-parameters-type branch May 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants