feat(app,robot-server): Subscribe to currentlyRecoveringFrom notifications
#15242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mark `RunHooks` and `EngineStateSlice` as private. * Rename `initialize()` to `start_publishing_for_run()`, because "initialize" was reading to me like a one-time thing for the instance. * Remove unused attributes. * Use "new" instead of "current" in variable names, because "current" already has a different meaning in "current command" and "currently recovering from."
For symmetry with how the field is named in the HTTP response.
SyntaxColoring
commented
May 21, 2024
SyntaxColoring
commented
May 21, 2024
SyntaxColoring
commented
May 22, 2024
SyntaxColoring
commented
May 22, 2024
SyntaxColoring
requested review from
ncdiehl11,
mjhuff and
a team
and removed request for
a team
mjhuff
reviewed
May 24, 2024
robot-server/robot_server/service/notifications/publishers/runs_publisher.py
Show resolved
Hide resolved
robot-server/robot_server/service/notifications/publishers/runs_publisher.py
Show resolved
Hide resolved
mjhuff
approved these changes
May 24, 2024
|
I'll probably test this on Monday and merge it then, assuming all goes well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-458.
Test plan
pickUpTipfailurepickUpTipfailure happensAnd maybe check the app or server logs to make sure it doesn't spam network requests, especially when notifications are unavailable.
Changelog
...current_commandMQTT topic, which was "the equivalent ofGET /runs/:runId/commands?cursor=null&pageLength=1, to...command_links, which is the equivalent of thelinksfield of anyGET /runs/:runId/commandsquery.linksupdate with a newcurrentlyRecoveringFromcommand ID, it will do a separateGET /runs/{id}/commands/{id}query to fetch the full details of the command.Review requests
Several frontend questions because I don't know what I'm doing there. See my GitHub comments below.
Risk assessment
Probably at least a medium risk of breaking recent unreleased work (#15170). Although we can cover these notifications hooks with tests, it doesn't look like those tests are in a good position to make sure the UI is actually doing the correct thing overall.