Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(api): Add a unit test for RQA-2737 #15216

Merged

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Penance for my bug.

Adds a unit test to cover RQA-2737, which @sfoster1 fixed in #15215.

Test Plan

I've made sure this fails without #15215 and passes with it.

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner May 17, 2024 21:49
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet sweet unit test!
Thank you!

error=RuntimeError(
"uh oh I was a command and then I got cancelled because someone"
" stopped the run, and now I'm raising this exception because"
" of that. Woe is me"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha 😂

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@SyntaxColoring SyntaxColoring changed the base branch from chore_release-7.3.0 to rqa-2737-surprise-errors May 17, 2024 22:32
@SyntaxColoring SyntaxColoring merged commit 26f9ada into rqa-2737-surprise-errors May 17, 2024
18 of 26 checks passed
@SyntaxColoring SyntaxColoring deleted the rqa-2737-surprise-errors-unit-tests branch May 17, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants