Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): restore empty error blocks on cancelled runs #15215

Merged
merged 3 commits into from
May 17, 2024
Merged

fix(api): restore empty error blocks on cancelled runs #15215

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97de8a3
this definitely should only happen with no result
sfoster1 May 17, 2024
4c30bf5
fix estop handling
sfoster1 May 17, 2024
26f9ada
test(api): Add a unit test for RQA-2737 (#15216)
SyntaxColoring May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/src/opentrons/protocol_engine/state/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,12 +384,12 @@ def handle_action(self, action: Action) -> None: # noqa: C901
else:
self._state.run_result = RunResult.STOPPED

if not self._state.run_error and action.error_details:
self._state.run_error = self._map_run_exception_to_error_occurrence(
action.error_details.error_id,
action.error_details.created_at,
action.error_details.error,
)
if not self._state.run_error and action.error_details:
self._state.run_error = self._map_run_exception_to_error_occurrence(
action.error_details.error_id,
action.error_details.created_at,
action.error_details.error,
)

elif isinstance(action, HardwareStoppedAction):
self._state.queue_status = QueueStatus.PAUSED
Expand Down
Loading