fix(app-testing): snapshot failure capture #15211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
6 times, most recently
from
855ab38 to
0c554b7
Compare
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
5 times, most recently
from
55837fe to
48bd802
Compare
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
from
48bd802 to
a66cb46
Compare
sanni-t
reviewed
May 31, 2024
...60373][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json
Outdated
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
7 times, most recently
from
bd7a503 to
0b04c7f
Compare
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
2 times, most recently
from
e808f52 to
8ee0f1b
Compare
3 tasks
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
from
8ee0f1b to
912a463
Compare
sanni-t
added a commit
that referenced
this pull request
Jun 13, 2024
Closes AUTH-486 # Overview Fixes the issues caught in #15211 Previously, RTP validation occurred as part of a simulating runner's run process. This run process executes the protocol inside a separate task, and any errors raised while running the task are wrapped and presented in the 'Rune result" as an analysis error. Now that RTP validation is happening as part of the runner load process, we have to handle the error raised in the load process in a similar way as well. This PR adds this missing error handling in `analyze` cli function. # Test Plan - [ ] Upload a protocol with incorrect RTP definition and verify that the in-app analysis fails with the correct error and no traceback in the error pop-up window. - [ ] Verify that the static data of the above protocol- metadata, requirements and files are populated in the failed analysis - [ ] Verify that any other, non-RTP-related errors raised during the runner load process are handled just like they would have in the previous stable software. # Risk assessment Medium. Updates a critical part of in-app analysis, but is a fix and is isolated to error handling of `runner.load` only.
github-actions
bot
force-pushed
the
app-testing/edge-from-edge
branch
from
912a463 to
7e1b9a0
Compare
SyntaxColoring
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Discussed with @y3rsh, @sanni-t, and @CaseyBatten in Slack.
test_analysis_snapshot[baf79d9b4a][Flex_S_v2_15_P1000S_None_SimpleNormalizeLongRight].json has tip length differences that @CaseyBatten is looking into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an automated snapshot update request. Please review the changes and merge if they are acceptable or find you bug and fix it.