Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): create well selection component #15207

Merged
merged 17 commits into from
May 20, 2024
Merged

feat(app): create well selection component #15207

merged 17 commits into from
May 20, 2024

Conversation

brenthagen
Copy link
Contributor

@brenthagen brenthagen commented May 16, 2024 •
edited
Loading

Overview

creates ODD well selection component for use in quick transfer. implements basic source and destination quick transfer well selection. based on SelectableLabware component in protocol designer.

closes PLAT-172, PLAT-175

TODO: tweak styling: selection rectangle layout, well labels
TODO: refactor labware render component to simplify Well component rendering and remove SVG well stroke

Screen Shot 2024-05-16 at 4 03 30 PM

Test Plan

verified touch selection on device

Changelog

  • Creates well selection component
  • Implements quick transfer source and destination well selection

Review requests

select some wells

Risk assessment

low

brenthagen added 12 commits May 8, 2024 16:23
@brenthagen
render WellSelection in SelectSourceWells
9f04a57
@brenthagen
Merge branch 'edge' into app_well-selection-component
fc7ef54
@brenthagen
hide labware outline, add well fill, well labels, reset button
8d826af
@brenthagen
Merge branch 'edge' into app_well-selection-component
e4df27b
@brenthagen
highlight rectangle selected wells
832c5b3
@brenthagen
convert selection rect to touch events
8880e03
@brenthagen
add mouse events for local development
ea52345
@brenthagen
initialize selected wells to reducer source wells value
fa563dd
@brenthagen
fix selection rect lint warnings
a52fff1
@brenthagen
implement basic destination well selection
bcc1186
@brenthagen
feat(app): create well selection component
dcf40af 
creates ODD well selection component for use in quick transfer. implements basic source and
destination quick transfer well selection.

closes PLAT-172, PLAT-175
@brenthagen
Merge branch 'edge' into app_well-selection-component
4d83f74
@brenthagen brenthagen requested a review from a team May 16, 2024 20:13
@brenthagen brenthagen marked this pull request as ready for review May 17, 2024 19:10
@brenthagen brenthagen requested a review from a team as a code owner May 17, 2024 19:10
@brenthagen brenthagen requested review from ncdiehl11 and removed request for a team and ncdiehl11 May 17, 2024 19:10
b-cooper
b-cooper reviewed May 20, 2024
View reviewed changes
app/src/organisms/WellSelection/index.tsx Outdated

interface WellSelectionProps {
definition: LabwareDefinition2
/** array of primary wells. Overrides labwareProps.selectedWells */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment still accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're no longer spreading labware props, no

@smb2268 smb2268 self-requested a review May 20, 2024 15:35
smb2268
smb2268 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! I tested it out on the dev app with a single, 8 and 96-channel and all worked as expected and wells are getting added to state properly.

b-cooper
b-cooper approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good ☑️

@brenthagen brenthagen merged commit 2760457 into edge May 20, 2024
34 checks passed
@brenthagen brenthagen deleted the app_well-selection-component branch May 20, 2024 16:30
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@brenthagen @Carlos-fernandez
feat(app): create well selection component (#15207)
959195a 
creates ODD well selection component for use in quick transfer.
implements basic source and destination quick transfer well selection.
based on SelectableLabware component in protocol designer.

closes PLAT-172, PLAT-175
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
@brenthagen @Carlos-fernandez
feat(app): create well selection component (#15207)
f4ecce4 
creates ODD well selection component for use in quick transfer.
implements basic source and destination quick transfer well selection.
based on SelectableLabware component in protocol designer.

closes PLAT-172, PLAT-175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smb2268 smb2268 smb2268 approved these changes

@b-cooper b-cooper b-cooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brenthagen @b-cooper @smb2268