Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(opentrons-ai-client): refactoring api call and inputprompt component #15193

Merged
merged 40 commits into from
May 29, 2024
Merged

refactor(opentrons-ai-client): refactoring api call and inputprompt component #15193

merged 40 commits into from
May 29, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented May 15, 2024 •
edited
Loading

Overview

refactoring api call and input prompt component
add a new package for testing axios

close AUTH-402

Test Plan

  1. make teardown-js && make setup-js
  2. make -C opentrons-ai-client dev
  3. open localhost:5173 (the port must be 5173 since the backend allows us to use only 5173 port)
  4. log in (if you don't have an account, you will need to sign up)
  5. send a prompt
    check the app displays your prompt and gets the return from OpenAI API

Changelog

  • add custom hook for callApi and get access token
  • export a function as a util function
  • update paragraph text style to align the font styles

Review requests

Risk assessment

low

koji added 23 commits May 9, 2024 15:01
@koji
feat(opentrons-ai-client): add auth0 package
bcde2a3 
add auth0 package

close AUTH-
@koji
Merge branch 'edge' into feat_add-auth0-provider
81435a3
@koji
add useAuth0 hook
7d4aa5a
@koji
update test for useAuth0
5268be1
@koji
Update App.test.tsx
be4f18a
@koji
add loading
9282701
@koji
fix test errors
3e04f05
@koji
remove any from test
c98fe92
@koji
add a test for logout function
70eab36
@koji
add loginWithRedirect
10dff35
@koji
remove unused link
95cab2c
@koji
centralize the link button
d48583e
@koji
Update App.tsx
0543ee9
@koji
update loading component
21eb39b
@koji
Merge branch 'edge' into feat_add-auth0-provider
db8bd8c
@koji
add getAccessTokenWithPopup
4db6477
@koji
update type to align with the be return type
0c560d1
@koji
switch back markdown of div
871e0ec
@koji
fix test errors
10f7b1e
@koji
Update index.tsx
476ee2c
@koji
refactor(opentrons-ai-client): refactoring api call and inputprompt c…
b1057e4 
…omponent

refactoring api call and inputprompt component

close AUTH-402
@koji
update a custom hook to get accessToken
529d4bd
@koji
add tests for useApiCall
b2a4100
@koji
Copy link
Contributor Author

koji commented May 15, 2024 •
edited
Loading

  • add a custom hook for data fetch
  • add a custom hook for token retrieving
  • update tests
  • add test for useGetAccessToken
  • fix fetch functionality
  • merge edge

@koji koji mentioned this pull request May 16, 2024
Merged
@koji koji marked this pull request as ready for review May 21, 2024 07:54
@koji koji requested a review from a team as a code owner May 21, 2024 07:54
@koji koji requested review from ncdiehl11, jerader and y3rsh and removed request for a team May 21, 2024 07:54
ncdiehl11
ncdiehl11 reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good, just having trouble testing the response after posting a prompt. Maybe we can chat IRL about how to test?

opentrons-ai-client/src/resources/utils/utils.ts Outdated Show resolved Hide resolved
@Elyorcv
Copy link
Contributor

Elyorcv commented May 21, 2024

@koji please rebase

@koji koji mentioned this pull request May 28, 2024
Merged
@y3rsh y3rsh mentioned this pull request May 29, 2024
Merged
y3rsh
y3rsh approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me against #15287

@koji koji merged commit f8ec80a into edge May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdiehl11 ncdiehl11 ncdiehl11 left review comments

@y3rsh y3rsh y3rsh approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koji @Elyorcv @y3rsh @ncdiehl11