feat(app): setup advanced settings/tip management state for quick transfer #15192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
commented
May 15, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix PLAT-227
Overview
This is a setup PR that doesn't add functionality. It adds the state and reducers needed for implementing the advanced settings and tip management portions of the quick transfer flow.
Test Plan
This doesn't impact functionality so no need to test
Changelog
QuickTransferSetupStatetoQuickTransferWizardStateQuickTransferSummaryStatetype andgetInitialSummaryStateutil that will generate the starting point for the state including default values based on what was selected in the wizard flow. There are a fewTODOcomments in here that will be addressed when those fields' screens are implemented.quickTransferSummaryReducerthat will allow us to amend the state based on selections made in the advanced settings and tip management fieldsReview requests
Look through utils for clarity
Risk assessment
Low, behind FF