refactor(api): Move opentrons.initialize() to its own file #15191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
commented
May 15, 2024
api/src/opentrons/_resources_path.py
Outdated
There was a problem hiding this comment.
I put this in its own file to keep it close to the resources/ directory that it's referencing. Otherwise we'd be trying to access it from inside hardware_control/ with some fragile relative path.
sfoster1
approved these changes
May 15, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
1 task
SyntaxColoring
added a commit
that referenced
this pull request
May 21, 2024
ryanthecoder
pushed a commit
that referenced
this pull request
May 28, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR #15171 runs into a circular import problem. We can fix it by paring down the contents of
api's top-level__init__.py, which might also have the benefit of improving performance (see explanation in PR #14480), so this does that. This goes towards EXEC-456.Test plan
None needed.
Changelog
Move
opentrons.initialize()toopentrons.hardware_control.initialization.initialize(), a new file.Review requests
_find_smoothie_file()function?opentrons.should_use_ot3(), which currently remains in the top-level__init__.py?Risk assessment
Low.