Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, components, protocol-designer, shared-data): import type lint rule to error, fix occurrences #15168

Merged
merged 8 commits into from
May 15, 2024

Conversation

b-cooper
Copy link
Contributor

Overview

Removes ~1000 lint warnings and standardizes the separation of type imports from module imports

Risk assessment

medium, no code should be effected, but touches many files

@b-cooper b-cooper requested a review from shlokamin May 10, 2024 21:45
@b-cooper b-cooper marked this pull request as ready for review May 14, 2024 16:00
@b-cooper b-cooper requested review from a team as code owners May 14, 2024 16:00
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@b-cooper b-cooper merged commit bda3836 into edge May 15, 2024
32 checks passed
@b-cooper b-cooper deleted the js_chew-through-eslint-warnings branch May 15, 2024 18:12
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
…t rule to error, fix occurrences (#15168)

Removes ~1000 lint warnings and standardizes the separation of type
imports from module imports
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
…t rule to error, fix occurrences (#15168)

Removes ~1000 lint warnings and standardizes the separation of type
imports from module imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants