Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentrons-ai-client): add code copy button #15126

Merged
merged 7 commits into from
May 10, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented May 7, 2024

Overview

add code copy button

Screen.Recording.2024-05-07.at.5.23.42.PM.mov

copy code button might be changed since the button hides the text.
Need to get feedback from product team.

align the button with Gradio style button
https://huggingface.co/spaces/Opentrons/OpentronsAI-v0.0.5

close AUTH-389

Test Plan

Changelog

Review requests

Risk assessment

add code copy button

close AUTH-389
@koji
Copy link
Contributor Author

koji commented May 7, 2024

  • add test cases

Sorry, something went wrong.

@koji koji marked this pull request as ready for review May 7, 2024 21:30
@koji koji requested a review from a team as a code owner May 7, 2024 21:30
@koji koji added the authorship label May 7, 2024
@koji koji marked this pull request as draft May 7, 2024 21:39
@koji koji marked this pull request as ready for review May 7, 2024 22:13
@koji koji requested review from ncdiehl11 and jerader and removed request for a team May 8, 2024 04:04
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, how can I test? I spun up the environment with make -C opentrons-ai-client dev but submitting a prompt doesn't seem to get a response

<PrimaryButton
position={POSITION_ABSOLUTE}
right={SPACING.spacing16}
bottom={`-${SPACING.spacing16}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an alternative to using a negative bottom spacing here? Like adding a top spacing?

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the video you provided lgtm and the code lgtm. I'm having similar issues as Nick and can't get a response from the ai when running only make -C opentrons-ai-client dev

koji added 2 commits May 10, 2024 00:42
@koji koji merged commit ddb373c into edge May 10, 2024
54 checks passed
@koji koji deleted the feat_add-code-copy-button branch May 10, 2024 05:37
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* feat(opentrons-ai-client): add code copy button
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
* feat(opentrons-ai-client): add code copy button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants