feat(api): add thermocycler control script #15118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
reviewed
May 7, 2024
|
|
||
| async def _main(): | ||
| tc_name = subprocess.check_output( | ||
| ["find", "/dev/", "-name", "*thermocycler*"] |
There was a problem hiding this comment.
fyi this will only work on a robot. we get these /dev/ things that are named after modules because we specify udev rules; it won't weven work on a non-robot linux computer.
There was a problem hiding this comment.
I might want to do a glob instead right
There was a problem hiding this comment.
or just document that it's only going to work on a robot if that's all it's intended to do. To make it work off of a robot, you'll have to use e.g. pyserial.tools.list_ports.comports rather than relying on files in particular directories
caila-marashaj
force-pushed
the
tc-message-script
branch
from
2eb254f to
b3c641d
Compare
sfoster1
approved these changes
May 14, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a debugging script that allows us to easily communicate with a thermocycler in a similar fashion to
can_controlorot3repl. It's just a control loop where the user is prompted to send a thermocycler command, and the script waits for and sends back the thermocycler's response.You can pass in any gcode command the thermocycler will recognize, and alternatively, there are a few shortcuts for commonly used debugging commands. For example, you can enter
olorclto open or close the lid.If there's a need for it in the future, this can likely also be modified to include other modules without that much change to the overall structure.
Review Requests
Update Notes
This is only meant for use on a robot. Once this is merged I'll write a doc explaining what this is and how to use it.