chore: Merge chore_release-7.3.0 into edge #15117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(app): modify slideout restore value link layout
* fix(app): fix the arrow icon size in dropdown menu
* fix(app): remove unnecessary padding
* fix(app): remove input field box-shadow on ODD
* fix(app): modify the space between icon and banner outline
* fix(app): fix input field behavior on blur
* fix(app): fix list button styling
* fix(app): fix space in mini card
…after waiting (#15103) Closes RQA-2677 ChangeNotifier is the interface for alerting robot-server of notification updates deriving from Protocol Engine. Protocol Engine notify()ies, and the PublisherNotifier wait()s. After the event flag is set() in notify(), the PublisherNotifier no longer waits (correctly). However, the event flag isn't cleared immediately on receiving a new event...it's cleared after PublisherNotifer fires all its registered callbacks. This causes some events to be dropped if Protocol Engine tries setting the flag before PublisherNotifier has gotten around to clearing it.
* fix(app): fix choose number input field behavior
mjhuff
requested review from
brenthagen,
sfoster1 and
a team
and removed request for
a team and
brenthagen
koji
approved these changes
May 7, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an incremental merge of the in-progress
chore_release-7.3.0branch intoedge.This gets the
ChangeNotifierinterface changes intoedge, needed for current notification work. Luckily, those changes were the only merge conflict.Risk assessment
low - only 1 conflict, and it was my conflict, anyway