-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add v2.18 smoke test protocol #14946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DerekMaggio should add something to handle #14940 if you haven't already |
DerekMaggio
force-pushed
the
add-v2.18-smoke-test-protocol
branch
from
May 2, 2024 14:44
f14490f
to
c04a5f5
Compare
nusrat813
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
# Overview Add 2.18 smoke tests for Flex and OT-2 Add change log to pass tests # Test Plan - [x] Test the tests by making sure the tests actually test things as they should be tested
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
# Overview Add 2.18 smoke tests for Flex and OT-2 Add change log to pass tests # Test Plan - [x] Test the tests by making sure the tests actually test things as they should be tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add 2.18 smoke tests for Flex and OT-2
Add change log to pass tests
Test Plan