feat(performance-metrics): store to file #14882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekMaggio
changed the base branch from
edge
to
EXEC-396-add-test-lint-github-action
sfoster1
approved these changes
Apr 12, 2024
| """Returns the stored context data and clears the storage list.""" | ||
| stored_data = self._storage.copy() | ||
| self._storage.clear() | ||
| rows_to_write = [context_data.csv_row() for context_data in stored_data] |
There was a problem hiding this comment.
we should probably sort this by start time before writing just in case - once we add various queues or whatever reordering might become possible
There was a problem hiding this comment.
Won't it always be sortable by start time regardless? My thought is ONLY robot context data would go in this file. Other metrics like CPU/Memory/Flash would be in a separate file. That way all this does is just push data to a file as fast as possible.
Then when those files are pulled for analysis they can be sorted at that time.
add workflow dispatch so I can test it chore: setup python correctly didn't add the right thing to test it why won't you run just run oh. my. gosh. run! argh sgdf i know I am doing something dumb sigh audible sigh yeah, I was doing something stupid well that was an adventure
DerekMaggio
force-pushed
the
EXEC-396-add-test-lint-github-action
branch
from
d42ab38 to
d75493a
Compare
Base automatically changed from
EXEC-396-add-test-lint-github-action
to
EXEC-384-robot-context-tracker
April 12, 2024 14:52
DerekMaggio
force-pushed
the
EXEC-377-store-to-file
branch
from
66601f0 to
abc128a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add functionality to store CSV data in a file
Test Plan
Changelog
storemethod to RobotContextTrackerReview requests
None
Risk assessment
Low