fix(api): module update process bug

[sanni-t]

Closes RQA-2417

Overview

Python 3.10 removed the loop param of create_subprocess_exec. This instance in firmware update process got left out and was not caught by the linter because the loop was being passed as a kwarg.

Test Plan

Test updating an arduino AVR module (temp/ mag) arduino SAMD module (thermocycler gen1) and an STM32 module (TC GEN2/ Heater-shaker).
I was able to successfully update the H/S with this change.

Review requests

• usual stuff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (d6d9416) to head (43bd7db).

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #14572      +/-   ##
==========================================
- Coverage   67.50%   67.50%   -0.01%     
==========================================
  Files        2514     2514              
  Lines       72376    72375       -1     
  Branches     9317     9317              
==========================================
- Hits        48857    48856       -1     
  Misses      21314    21314              
  Partials     2205     2205              

Flag	Coverage Δ
app	63.99% <ø> (ø)
components	48.40% <ø> (ø)
g-code-testing	92.43% <ø> (ø)
labware-library	41.11% <ø> (ø)
protocol-designer	37.90% <ø> (ø)
step-generation	86.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...i/src/opentrons/hardware_control/modules/update.py	27.69% <ø> (-1.10%)	⬇️
...ver/robot_server/service/legacy/routers/modules.py	98.36% <ø> (ø)

[sfoster1]

I sort of scooped you on this one sorry: 6c5a6dc

[sanni-t]

I have more stuff in here than your PR @sfoster1 😛
Surprised it's not giving a merge conflict on the removal of loop kwarg, but I've fully removed the loop arg from the function def & call as well. So this can still be merged instead of closing.

[sfoster1]

I have more stuff in here than your PR @sfoster1 😛 Surprised it's not giving a merge conflict on the removal of loop kwarg, but I've fully removed the loop arg from the function def & call as well. So this can still be merged instead of closing.

That's the best part about kwargs, it's a javascript like experience free of pesky runtime checks

[sanni-t]

To be rebased and merged in edge after 7.0.2 mergeback

[sfoster1]

Looks good to me, thank you!