Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Do not pass loop arg to subproc #14570

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

sfoster1
Copy link
Member

asyncio subprocess used to need loop; now it doesn't. For a minimum-affected fix, just don't pass loop to the subprocess invocations while keeping it in the top level environment.

Closes RQA-2417

asyncio subprocess used to need loop; now it doesn't. For a
minimum-affected fix, just don't pass loop to the subprocess invocations
while keeping it in the top level environment.

Closes RQA-2417
@sfoster1 sfoster1 requested a review from a team as a code owner February 29, 2024 19:27
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are the weakest loop, goodbye

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.75%. Comparing base (d792317) to head (d258156).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.0   #14570   +/-   ##
====================================================
  Coverage                67.75%   67.75%           
====================================================
  Files                     2521     2521           
  Lines                    72207    72207           
  Branches                  9293     9293           
====================================================
  Hits                     48922    48922           
  Misses                   21064    21064           
  Partials                  2221     2221           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/src/opentrons/hardware_control/modules/update.py 28.78% <ø> (ø)

@DerekMaggio
Copy link
Contributor

Installed this branch on the robot, was able to update my Heater-Shaker successfully. Thanks!

@sfoster1 sfoster1 merged commit 6c5a6dc into chore_release-7.2.0 Feb 29, 2024
22 checks passed
@sfoster1 sfoster1 deleted the RQA-2417-module-updates branch February 29, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants