Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing): add provisioning script for the Hepa/UV Module. #14561

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Feb 28, 2024

Overview

We need to write the serial number to the EEPROM of the Hepa/UV module at the factory, this provisioning script lets us do that.

Closes: RET-1427

Test Plan

  • Make sure that we can only write valid serial numbers to the EEPROM
  • Make sure that the device reports the correct serial number after writing and a power cycle

Changelog

  • Add a provisioning script for the Hepa/UV module to be used at the factory

Review requests

Risk assessment

Low, test software

@vegano1 vegano1 requested a review from a team as a code owner February 28, 2024 17:08
@vegano1 vegano1 requested a review from sfoster1 February 28, 2024 17:10
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 67.72%. Comparing base (9db4b55) to head (39feeb6).
Report is 8 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14561      +/-   ##
==========================================
- Coverage   67.80%   67.72%   -0.09%     
==========================================
  Files        2516     2517       +1     
  Lines       72154    72243      +89     
  Branches     9279     9279              
==========================================
- Hits        48925    48924       -1     
- Misses      21011    21101      +90     
  Partials     2218     2218              
Flag Coverage Δ
hardware 57.22% <0.00%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...are/opentrons_hardware/scripts/provision_hepauv.py 0.00% <0.00%> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vegano1 vegano1 merged commit d080d04 into edge Feb 28, 2024
14 of 15 checks passed
@vegano1 vegano1 deleted the RET-1427_add-hepauv-provision-script branch February 28, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants