Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app,components): change link color globally, fix location conflict modal styling #14540

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix(app,components): change link color globally, fix location conflict modal styling #14540

merged 2 commits into from
Feb 23, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

changes link color and hover color, fixes location conflict modal background color, text color, and layout

closes RAUT-968, RAUT-1013

Test Plan

verified match to figma

Changelog

  • Change link color globally, fix location conflict modal styling

Review requests

confirm match to figma

Risk assessment

low

@brenthagen
fix(app,components): change link color globally, fix location conflic…
84f24f2 
…t modal styling

changes link color and hover color, fixes location conflict modal background color, text color, and
layout

closes RAUT-968, RAUT-1013
@brenthagen brenthagen requested a review from a team February 22, 2024 14:32
@brenthagen brenthagen requested a review from a team as a code owner February 22, 2024 14:32
@brenthagen brenthagen requested review from smb2268 and removed request for a team February 22, 2024 14:32
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (4e42317) to head (b81e7af).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.0   #14540   +/-   ##
====================================================
  Coverage                67.74%   67.74%           
====================================================
  Files                     2517     2517           
  Lines                    72085    72085           
  Branches                  9282     9282           
====================================================
  Hits                     48834    48834           
  Misses                   21033    21033           
  Partials                  2218     2218
Flag Coverage Δ
app 64.64% <ø> (ø)
components 48.29% <ø> (ø)
labware-library 41.11% <ø> (ø)
protocol-designer 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...olRun/SetupModuleAndDeck/LocationConflictModal.tsx 65.00% <ø> (ø)
components/src/ui-style-constants/typography.ts 100.00% <ø> (ø)

@brenthagen brenthagen removed the request for review from smb2268 February 22, 2024 14:33
mjhuff
mjhuff approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@brenthagen brenthagen merged commit 4c44d7c into chore_release-7.2.0 Feb 23, 2024
35 checks passed
@brenthagen brenthagen deleted the app_link-color-and-location-conflict-modal branch February 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenthagen @mjhuff