-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): Update protocol page colors to helix designs #14534
refactor(app): Update protocol page colors to helix designs #14534
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14534 +/- ##
=======================================================
- Coverage 67.76% 67.74% -0.03%
=======================================================
Files 2517 2517
Lines 72059 72111 +52
Branches 9276 9295 +19
=======================================================
+ Hits 48833 48852 +19
- Misses 21008 21035 +27
- Partials 2218 2224 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! i saw the comment you left in RAUT-988, i think what you did make sense but maybe wait until Mel responds before merging?
Closes RAUT-987, RQA-2356, RAUT-988, RAUT-973, RAUT-980, and RAUT-981
Overview
Yep, it's another round of DQA color migration refactors, this time with a bonus RQA ticket (that's a DQA ticket in disguise)! Often, a few of the items within each ticket were resolved with changes already merged from other DQA PRs.
Test Plan
Risk assessment
low