Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Update protocol page colors to helix designs #14534

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 21, 2024

Closes RAUT-987, RQA-2356, RAUT-988, RAUT-973, RAUT-980, and RAUT-981

Overview

Yep, it's another round of DQA color migration refactors, this time with a bonus RQA ticket (that's a DQA ticket in disguise)! Often, a few of the items within each ticket were resolved with changes already merged from other DQA PRs.

Test Plan

  • Verify code changes resolve tickets listed above. If changes were not made within the PR, verify the correct changes were already merged (by running the dev environment from this branch).

Risk assessment

low

@mjhuff mjhuff requested a review from a team February 21, 2024 16:55
@mjhuff mjhuff requested a review from a team as a code owner February 21, 2024 16:55
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team February 21, 2024 16:55
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7b456ed) 67.76% compared to head (f5e7c36) 67.74%.
Report is 3 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14534      +/-   ##
=======================================================
- Coverage                67.76%   67.74%   -0.03%     
=======================================================
  Files                     2517     2517              
  Lines                    72059    72111      +52     
  Branches                  9276     9295      +19     
=======================================================
+ Hits                     48833    48852      +19     
- Misses                   21008    21035      +27     
- Partials                  2218     2224       +6     
Flag Coverage Δ
app 64.65% <33.33%> (+0.01%) ⬆️
components 48.29% <25.00%> (-0.62%) ⬇️
labware-library 41.11% <ø> (ø)
protocol-designer 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/atoms/InstrumentContainer/index.tsx 100.00% <ø> (ø)
app/src/atoms/buttons/ToggleButton.tsx 100.00% <ø> (ø)
...ices/ProtocolRun/SetupLiquids/SetupLiquidsList.tsx 89.18% <ø> (ø)
...pp/src/organisms/DropTipWizard/BeforeBeginning.tsx 44.00% <ø> (ø)
...ganisms/ProtocolDetails/ProtocolLiquidsDetails.tsx 90.00% <ø> (ø)
...isms/ProtocolDetails/RobotConfigurationDetails.tsx 81.48% <ø> (ø)
app/src/organisms/ProtocolDetails/index.tsx 41.75% <ø> (ø)
...pp/src/organisms/ProtocolsLanding/ProtocolCard.tsx 0.00% <ø> (ø)
...pp/src/organisms/ProtocolsLanding/ProtocolList.tsx 68.18% <ø> (ø)
app/src/organisms/RunProgressMeter/index.tsx 63.33% <ø> (ø)
... and 4 more

... and 4 files with indirect coverage changes

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! i saw the comment you left in RAUT-988, i think what you did make sense but maybe wait until Mel responds before merging?

@mjhuff mjhuff merged commit 4e42317 into chore_release-7.2.0 Feb 21, 2024
34 of 35 checks passed
@mjhuff mjhuff deleted the app_update-protocol-pages-to-helix-colors branch February 21, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants