-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): update desktop special-case colors #14524
refactor(app): update desktop special-case colors #14524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14524 +/- ##
====================================================
Coverage 67.79% 67.79%
====================================================
Files 2518 2518
Lines 72459 72460 +1
Branches 9276 9276
====================================================
+ Hits 49123 49124 +1
Misses 21118 21118
Partials 2218 2218
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! question, is style()
the correct way to categorize this PR? see this slack post from a few years ago: https://opentrons.slack.com/archives/CMGV77JP4/p1656442016461519
@@ -60,12 +60,12 @@ export const blue10 = '#F1F8FF' | |||
*/ | |||
export const grey60 = '#4A4C4E' | |||
export const grey55 = '#737578' | |||
export const grey50 = '#9C9C9C' | |||
export const grey50 = '#737578' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice this is the grey i noticed was slightly off, thanks for fixing it here!
Woops, you're totally right. This should be a refactor. |
Closes RAUT-970, RAUT-997, RAUT-998, RAUT-999, RAUT-1000, RAUT-1002, and RAUT-1004
Overview
Updates the colors for one-off desktop components. See tickets for specific changes.
Test Plan
Risk assessment
low