Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): update desktop special-case colors #14524

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 20, 2024

Closes RAUT-970, RAUT-997, RAUT-998, RAUT-999, RAUT-1000, RAUT-1002, and RAUT-1004

Overview

Updates the colors for one-off desktop components. See tickets for specific changes.

Test Plan

  • Just look at the tickets and verify changes were made to appropriate components.
  • See comments within RAUT-1004 and RAUT-1002 for changes.

Risk assessment

low

@mjhuff mjhuff requested a review from a team February 20, 2024 16:21
@mjhuff mjhuff requested a review from a team as a code owner February 20, 2024 16:21
@mjhuff mjhuff requested review from brenthagen and removed request for a team February 20, 2024 16:21
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad6c1a2) 67.79% compared to head (8c30a07) 67.79%.
Report is 1 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.0   #14524   +/-   ##
====================================================
  Coverage                67.79%   67.79%           
====================================================
  Files                     2518     2518           
  Lines                    72459    72460    +1     
  Branches                  9276     9276           
====================================================
+ Hits                     49123    49124    +1     
  Misses                   21118    21118           
  Partials                  2218     2218           
Flag Coverage Δ
app 64.64% <100.00%> (+<0.01%) ⬆️
components 48.90% <100.00%> (ø)
labware-library 41.11% <ø> (ø)
protocol-designer 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/molecules/JogControls/StepSizeControl.tsx 51.72% <ø> (ø)
app/src/molecules/WizardHeader/index.tsx 100.00% <ø> (ø)
...edTab/AdvancedTabSlideouts/DeviceResetSlideout.tsx 61.29% <ø> (ø)
...s/LabwareDetails/StyledComponents/LabeledValue.tsx 100.00% <ø> (ø)
app/src/organisms/TaskList/index.tsx 93.40% <100.00%> (+0.07%) ⬆️
...omponents/src/atoms/buttons/AlertPrimaryButton.tsx 100.00% <ø> (ø)
components/src/helix-design-system/colors.ts 80.39% <100.00%> (ø)

@mjhuff mjhuff changed the title App update desktop special case colors style(app): update desktop special-case colors Feb 20, 2024
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! question, is style() the correct way to categorize this PR? see this slack post from a few years ago: https://opentrons.slack.com/archives/CMGV77JP4/p1656442016461519

@@ -60,12 +60,12 @@ export const blue10 = '#F1F8FF'
*/
export const grey60 = '#4A4C4E'
export const grey55 = '#737578'
export const grey50 = '#9C9C9C'
export const grey50 = '#737578'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this is the grey i noticed was slightly off, thanks for fixing it here!

@mjhuff
Copy link
Contributor Author

mjhuff commented Feb 20, 2024

lgtm! question, is style() the correct way to categorize this PR? see this slack post from a few years ago: https://opentrons.slack.com/archives/CMGV77JP4/p1656442016461519

Woops, you're totally right. This should be a refactor.

@mjhuff mjhuff changed the title style(app): update desktop special-case colors refactor(app): update desktop special-case colors Feb 20, 2024
@mjhuff mjhuff merged commit 36fb1ce into chore_release-7.2.0 Feb 20, 2024
55 of 56 checks passed
@mjhuff mjhuff deleted the app_update-desktop-special-case-colors branch February 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants