refactor(protocol-designer): ot-2 slot map is now a normal size

[jerader]

closes RAUT-1005

Overview

See the ticket. no idea when this error was introduced - apparently after i did the migration to react-hook-form?? Weird. But anyway, I fixed it here and also cleaned up the SlotMap components, getting rid of the no longer needed ConnectSlotMap

Bonus: also there was a small bug with the well selection field where it was defaulting the value to 0 which is different from PD in prod. So i fixed that up really quick too.

Test Plan

Create an Ot-2 protocol and edit the modules. See that the slot map is no longer way too big.

Changelog

• clean up the SlotMap component and associated components
• fix test
• fix bug with well selection field where it was defaulting the value to 0 if the length of well array was 0.

Review requests

see test plan

Risk assessment

low

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb0d4e6) 67.81% compared to head (a4ff7c0) 67.81%.
Report is 20 commits behind head on edge.

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #14518      +/-   ##
==========================================
- Coverage   67.81%   67.81%   -0.01%     
==========================================
  Files        2518     2517       -1     
  Lines       72108    72154      +46     
  Branches     9274     9274              
==========================================
+ Hits        48898    48928      +30     
- Misses      20995    21008      +13     
- Partials     2215     2218       +3     

Flag	Coverage Δ
app	64.64% <ø> (-0.01%)	⬇️
labware-library	41.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...r/src/components/modals/EditModulesModal/index.tsx	70.96% <100.00%> (+0.31%)	⬆️
...ocol-designer/src/components/modules/ModuleRow.tsx	0.00% <ø> (ø)
...m/fields/WellSelectionField/WellSelectionField.tsx	2.85% <0.00%> (ø)

... and 23 files with indirect coverage changes

[jerader]

unrelated to the bug but this fixed another small bug i found that was introduced by my PR that refactored class components into functional components 😬

[mjhuff]

Looks good! IMO, I wouldn't be opposed to naming SlotMap to something like OT2SlotMap or leaving a docstring explaining that this is an OT-2 specific component, since we have an analogous FlexSlotMap.

[jerader]

Looks good! IMO, I wouldn't be opposed to naming SlotMap to something like OT2SlotMap or leaving a docstring explaining that this is an OT-2 specific component, since we have an analogous FlexSlotMap.

@mjhuff good call! thank you! SlotMap used to be used for both robot types so I forgot that I made a FlexSlotMap later. I'll rename it to OT2SlotMap