Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): remove subsystem update link from instrument card #14507

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Feb 15, 2024

fix RQA-2328

Overview

We're going to remove the ability to update a subsystem from the app-side instrument card and force users to initiate these updates on the ODD.

Test Plan

Attach a pipette that needs a firmware update to the robot (outside of an in-app attachment flow)
See that on the app's instrument card, the new copy is displayed in the red banner

Changelog

  1. Remove firmware update modal from the pipette and gripper cards
  2. Update copy to direct users to go to the ODD to update the instrument

Review requests

Look over changes

Risk assessment

Low

@smb2268 smb2268 self-assigned this Feb 15, 2024
@smb2268 smb2268 requested a review from a team as a code owner February 15, 2024 21:41
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dc44b0) 67.70% compared to head (3edd32e) 67.82%.
Report is 29 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14507      +/-   ##
=======================================================
+ Coverage                67.70%   67.82%   +0.12%     
=======================================================
  Files                     1628     2519     +891     
  Lines                    54904    72733   +17829     
  Branches                  4147     9575    +5428     
=======================================================
+ Hits                     37172    49333   +12161     
- Misses                   17042    21170    +4128     
- Partials                   690     2230    +1540     
Flag Coverage Δ
app 64.62% <100.00%> (+30.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/src/organisms/Devices/InstrumentsAndModules.tsx 70.00% <ø> (ø)
app/src/organisms/Devices/PipetteCard/index.tsx 54.54% <ø> (ø)
app/src/organisms/GripperCard/index.tsx 82.05% <100.00%> (ø)

... and 893 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's way easier.

@smb2268 smb2268 merged commit 7822a91 into chore_release-7.2.0 Feb 16, 2024
22 checks passed
@smb2268 smb2268 deleted the app_instrument-card-subsystem branch February 16, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants