Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Remove notification event emitters #14504

Merged
merged 3 commits into from
Feb 16, 2024

test

f3a2bb3
Select commit
Loading
Failed to load commit list.
Merged

refactor(app): Remove notification event emitters #14504

test
f3a2bb3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 16, 2024 in 1s

67.76% (+0.02%) compared to 9dc8f2d

View this Pull Request on Codecov

67.76% (+0.02%) compared to 9dc8f2d

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9dc8f2d) 67.74% compared to head (f3a2bb3) 67.76%.
Report is 5 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14504      +/-   ##
=======================================================
+ Coverage                67.74%   67.76%   +0.02%     
=======================================================
  Files                     2517     2517              
  Lines                    72068    72055      -13     
  Branches                  9278     9276       -2     
=======================================================
+ Hits                     48823    48829       +6     
+ Misses                   21027    21008      -19     
  Partials                  2218     2218              
Files Coverage Δ
app/src/resources/useNotifyService.ts 84.61% <100.00%> (+48.90%) ⬆️
app/src/redux/shell/remote.ts 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes