feat(api,hardware): add hepa/uv config/control commands to api. #14489
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## edge #14489 +/- ##
==========================================
+ Coverage 67.79% 67.82% +0.02%
==========================================
Files 2518 2519 +1
Lines 72017 72082 +65
Branches 9244 9244
==========================================
+ Hits 48826 48887 +61
- Misses 20989 20993 +4
Partials 2202 2202
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| return await set_hepa_uv_state_fw(self._messenger, light_on, timeout_s) | ||
|
|
||
| async def get_hepa_uv_state(self) -> Optional[HepaUVState]: | ||
| res = await get_hepa_uv_state_fw(self._messenger) |
There was a problem hiding this comment.
Are you not just returning res here because of linter complaining?
There was a problem hiding this comment.
its to separate opentrons_hardware dataclasses from opentrons.hardware_control ones.
| return await self._backend.get_hepa_fan_state() | ||
|
|
||
| async def set_hepa_uv_state( | ||
| self, turn_on: bool = False, timeout_s: int = 900 |
There was a problem hiding this comment.
Do we need this long of a timeout?
There was a problem hiding this comment.
yeah 900s (15m) is the default uv light timeout
There was a problem hiding this comment.
can we call it like dose_duration or something?
| return await self._backend.get_hepa_fan_state() | ||
|
|
||
| async def set_hepa_uv_state( | ||
| self, turn_on: bool = False, timeout_s: int = 900 |
There was a problem hiding this comment.
can we call it like dose_duration or something?
…means how long to turn the uv light on for.
Overview
We added can messages to control the hepa/uv in this pr (Opentrons/opentrons:#14452), now we want to use those messages from the hardware controller and API. This pr adds the hooks to these can messages so they can be used from repl.
Closes: RET-1424
Test Plan
Changelog
Review requests
Risk assessment
low, unreleased
Todo