-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge v7.2.0-alpha.1 into edge #14453
Conversation
* chore: verbose pypi deploys to catch errors * let's push an sdist while we're at it
…al tip movement (#14426) * added pipette bounds fetch and height check on overlapping slots --------- Co-authored-by: CaseyBatten <[email protected]>
* feat(app): add privacy policy acknowledgement screen to new 7.2 bootup on ODD closes RAUT-818
…nts in FLEX (#14437) * use prepare_for_mount_movement and add home_if_idle for ot3 gantry position call
This is a PRs to update python dependencies to modern versions. This one stops at the major breaking change point of pydantic 2.0. While Pydantic 2.0 is apparently much much faster (it's written in rust if you can believe it) it also makes a bunch of breaking api changes and in theory provides back-compat patches. Similarly, fastapi 0.100.0 switches internally to depend on pydantic 2, with similarly theoretical back compat patches. So, we've updated to, Dependency Version Changes In prod, major deps (full list is essentially entirely in the robot-server pipfile, see below for why): - fastapi 0.99.0 (from 0.68.1) - pydantic 1.10.12 (from 1.9.2) - uvicorn 0.27.0 (from 0.14.0) - sqlalchemy 1.4.51 (from 1.4.32 - bigger change than you think, and breaking changes above this) In dev tooling, - mypy 1.8.0 (from 0.981) - flake8 7 (from like 3 or something we never updated this) - mock 5 (from 4) - decoy 2 (from 1) - pytest 7.4.4 except robot-server, which is limited by tavern to 7.3 (from various) - tavern 2.9.1 (from 1.6) Version Definition Changes Some people want to use our python libraries that are published on pypi. The problem with this is that our libraries - opentrons and opentrons_shared_data have explicit version pinning in their setup.py install_requires, which makes it incredibly hard for them to coexist with other python packages that aren't comaintained by us (see #11912 , #12839 ). One way to fix this would be version ranges in the setup.py and explicit versions (that are contained within those ranges, and that match or define what's present on the robot) in the pipfiles. We couldn't do this because pipenv had problems with it. Now, however, we've upgraded pipenv, and that strategy works! And since I was going around bumping all the deps anyway, I could figure out what the actual functional dependency version boundaries were. So as part of this, opentrons (api/setup.py) and opentrons_shared_data (shared-data/python/setup.py) now have version ranges for all of their install_requires that aren't other opentrons packages, and I'm pretty sure about those version ranges. They may be smaller than would be ideal, but they're real.
When a module gets disconnected, the hardware controller cleans up the module instance, which stops the poller. What it doesn't do is cancel anything that was waiting on the next poll, or in fact prevent new things from waiting on the now-stopped poller. That means that if a module disconnects - During a module method waiting for the next poll, that module method hangs (well, awaits) forever - During a module method right _before_ waiting for the next poll, that module method would start waiting and continue waiting forever This PR forwards cancellations into the registered poll waiters when the poller task is cancelled, and prevents the registration of new poll waiters on a cancelled poll task.
* fix(app): fix odd protocol setup background color fix odd protocol setup background color Close RAUT-961
external links were opening in the electron browser window instead of an external browser window closes RQA-2309
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## edge #14453 +/- ##
==========================================
- Coverage 68.14% 67.77% -0.37%
==========================================
Files 2518 2518
Lines 72009 71968 -41
Branches 9232 9244 +12
==========================================
- Hits 49067 48777 -290
- Misses 20743 20989 +246
- Partials 2199 2202 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Remember: normal merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Thank you!
Overview
#14442 is currently in the release branch, but not in edge. We should bring it into edge quickly to stop people from corrupting their robots' storage when they're working on an edge-based dev branch.
Test Plan
None needed.
Review requests
None needed here. These changes were all already reviewed in other PRs.
Risk assessment
Low.