Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): deprecate formik, migrate to react-hook-form #14424

Merged
merged 13 commits into from
Feb 28, 2024

add id to form

867e8ec
Select commit
Loading
Failed to load commit list.
Merged

feat(app): deprecate formik, migrate to react-hook-form #14424

add id to form
867e8ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2024 in 1s

67.86% (+0.09%) compared to 63a20fc

View this Pull Request on Codecov

67.86% (+0.09%) compared to 63a20fc

Details

Codecov Report

Attention: Patch coverage is 70.81081% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 67.86%. Comparing base (63a20fc) to head (867e8ec).
Report is 68 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14424      +/-   ##
==========================================
+ Coverage   67.77%   67.86%   +0.09%     
==========================================
  Files        2518     2519       +1     
  Lines       71968    73051    +1083     
  Branches     9244     9722     +478     
==========================================
+ Hits        48774    49577     +803     
- Misses      20990    21201     +211     
- Partials     2204     2273      +69     
Files Coverage Δ
...src/organisms/AppSettings/ManualIpHostnameForm.tsx 96.42% <95.00%> (+4.42%) ⬆️
...ings/ConnectNetwork/ConnectModal/SecurityField.tsx 23.07% <0.00%> (ø)
...edTab/AdvancedTabSlideouts/RenameRobotSlideout.tsx 92.45% <93.54%> (+11.05%) ⬆️
...tings/ConnectNetwork/ConnectModal/KeyFileField.tsx 25.00% <0.00%> (ø)
...Settings/ConnectNetwork/ConnectModal/TextField.tsx 14.28% <0.00%> (ø)
app/src/pages/NameRobot/index.tsx 82.60% <93.75%> (+9.72%) ⬆️
...Settings/ConnectNetwork/ConnectModal/FormModal.tsx 33.33% <16.66%> (-5.56%) ⬇️
...src/organisms/ConfigurePipette/ConfigFormGroup.tsx 50.00% <50.00%> (-2.00%) ⬇️
...ettings/ConnectNetwork/ConnectModal/form-fields.ts 84.41% <57.14%> (-12.73%) ⬇️
app/src/organisms/ConfigurePipette/ConfigForm.tsx 75.29% <82.22%> (+1.22%) ⬆️
... and 2 more

... and 52 files with indirect coverage changes