-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): fix dqa ODD protocol setup deck config #14169
fix(app): fix dqa ODD protocol setup deck config #14169
Conversation
fix ODD protocol setup deck config close RAUT-834
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14169 +/- ##
=======================================================
- Coverage 70.46% 70.35% -0.12%
=======================================================
Files 2512 2512
Lines 71220 71388 +168
Branches 8974 9032 +58
=======================================================
+ Hits 50187 50224 +37
- Misses 18837 18964 +127
- Partials 2196 2200 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also in protocol_setup.json
, to match figma should be
"multiple_fixtures_missing": "{count}} fixtures missing",
…n in ProtocolSetup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Overview
fix ODD protocol setup deck config.
This PR will close the 2nd item, 3rd item, and 4th item in RAUT-834.
For Deck view height, it took from
components/src/hardware-sim/DeckConfigurator/index.tsx
protocol setup
modules & deck
Test Plan
96_ch Tip Drop 200uL_Tip Rack Drop Well Plate Drop Waste chute no cover (2).json.zip
Changelog
currentDeckConfig,
in ProtocolSetupDeckConfigurationReview requests
I'd like to hear suggestion to fix Deck view size modification since I don't think the change in this pr is really good.
Risk assessment
low