Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): case insensitively sort labware list #14165

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

shlokamin
Copy link
Member

Overview

This PR ignores case when sorting labware display names in the app's labware list.

closes RQA-1955

Risk assessment

Low

@shlokamin shlokamin requested review from koji and jerader December 11, 2023 21:25
@shlokamin shlokamin requested a review from a team as a code owner December 11, 2023 21:25
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #14165 (9a00a91) into chore_release-7.1.0 (6f14276) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14165   +/-   ##
====================================================
  Coverage                70.45%   70.46%           
====================================================
  Files                     2512     2512           
  Lines                    71219    71219           
  Branches                  8971     8971           
====================================================
+ Hits                     50179    50182    +3     
+ Misses                   18844    18843    -1     
+ Partials                  2196     2194    -2     
Flag Coverage Δ
app 67.67% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/pages/Labware/hooks.tsx 82.92% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shlokamin shlokamin merged commit 11d65b3 into chore_release-7.1.0 Dec 11, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants