fix(api): clean up tip motor distance caching/usage #14156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
RQA-2038 seems to be related to the Tip Check that occurs when cancelling a protocol. The Serialization error was a result of the software attempting to send a move group with a duration far exceeding a 32-bit integer. I was able to replicate the issue by cancelling a run during the setup stage, and then re-entering setup at a time such that a Tip Motor home action got interrupted, leaving the tip motors with a "motor_position" estimate that is orders of magnitude higher than the actual max position of the axis.
Once the tip motor is in this situation, the software will fail a subsequent Tip Presence Check because of the invalid cached position of the motor.
To fix this, I added a few bandaids
With all of these changes, I can no longer replicate the issue.
Test Plan
Replication is mentioned above.
Changelog
Listed above
Review requests
Risk assessment
Medium/low, doesn't touch anything too integral