-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: 7.1.0 testing protocols #14135
Conversation
add pipetting
…testing_protocols
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14135 +/- ##
=======================================================
+ Coverage 70.43% 70.47% +0.04%
=======================================================
Files 1636 2512 +876
Lines 54506 71219 +16713
Branches 4024 8974 +4950
=======================================================
+ Hits 38391 50192 +11801
- Misses 15418 18831 +3413
- Partials 697 2196 +1499
Flags with carried forward coverage won't be shown. Click here to find out more. |
also update names and spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but should it not target edge
?
I'm eager to rebase on this to further enhance the snapshots.
Retargeted, thank you for catching that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
Important
The ABR testing protocols are currently failing, and will not be fixed in this PR
@y3rsh is fixing them
Test Plan
Changelog
Protocols Added
Print Protocols Script
Added printing of protocols mapped in protocols.py, but have no corresponding file in the protocols directory. This was useful when I changed the name of some of the protocols. It helped me make sure I didn't have test definitions that were not connected to a protocol.
Protocol Analysis Testing Updates
Review requests
Risk assessment
Extremely low, not run in CI, nothing depends on this