ci(shared-data, components): add github action for publishing packages to npm #14077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14077 +/- ##
==========================================
Coverage 70.46% 70.46%
==========================================
Files 2511 1633 -878
Lines 71194 54520 -16674
Branches 8952 4026 -4926
==========================================
- Hits 50165 38420 -11745
+ Misses 18849 15403 -3446
+ Partials 2180 697 -1483
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
reviewed
Dec 1, 2023
b-cooper
commented
Dec 5, 2023
| @@ -61,7 +61,6 @@ setup-js: | |||
| yarn | |||
| $(MAKE) -C $(APP_SHELL_DIR) setup | |||
| $(MAKE) -C $(APP_SHELL_ODD_DIR) setup | |||
| $(MAKE) -C $(SHARED_DATA_DIR) setup-js | |||
There was a problem hiding this comment.
this call is no longer necessary.
b-cooper
commented
Dec 5, 2023
|
|
||
| .PHONY: dist-js |
There was a problem hiding this comment.
these were purely used for bundling v1 labware defs for old versions of monorepo SPA's
…s to npm In order to support a single source of truth for applications outside of the monorepo (read: "Protocol Library") that rely on fundamental components and geometries within the mono repo, add tag based deploy actions that publish bundled artifacts to NPM.
b-cooper
changed the title
b-cooper
commented
Dec 5, 2023
| @@ -115,14 +106,7 @@ export class URLDeck extends React.Component<{}> { | |||
| > | |||
| {labwareDefV2 ? ( | |||
| <LabwareRender definition={labwareDefV2} /> | |||
| ) : ( | |||
There was a problem hiding this comment.
this whole directory will never be deployed again. It can be removed when legacy PL is unlisted
sfoster1
approved these changes
Dec 5, 2023
| @@ -115,14 +106,7 @@ export class URLDeck extends React.Component<{}> { | |||
| > | |||
| {labwareDefV2 ? ( | |||
| <LabwareRender definition={labwareDefV2} /> | |||
| ) : ( | |||
shlokamin
reviewed
Dec 5, 2023
| echo "No build for ref ${{github.ref}} and event ${{github.event_type}}" | ||
| echo 'type=none' >> $GITHUB_OUTPUT | ||
| fi | ||
|
|
||
| deploy-components: |
There was a problem hiding this comment.
Suggested change
| deploy-components: | |
| deploy-components-storybook: |
ncdiehl11
pushed a commit
that referenced
this pull request
Dec 19, 2023
…s to npm (#14077) In order to support a single source of truth for applications outside of the monorepo (read: "Protocol Library") that rely on fundamental components and geometries within the mono repo, add tag based deploy actions that publish bundled artifacts to NPM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In order to support a single source of truth for applications outside of the monorepo (read:
"Protocol Library") that rely on fundamental components and geometries within the mono repo, add tag
based deploy actions that publish bundled artifacts to NPM.
Changelog
Review requests
Risk assessment