Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Pipette and Gripper flow design fixes #14076

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 30, 2023

fix RQA-1963, RQA-1946

Overview

This resolves a few styling related bugs:

  1. Use "Pipette" if pipette name is missing on still attached error screen so copy will read "Pipette still attached" instead of "still attached"
  2. Add margin to subheader on simple wizard body screen so that it doesn't overlap with the buttons if the copy is more than one line - see screenshot
  3. Capitalize exit CTA on gripper success screen
Screen Shot 2023-11-30 at 5 36 38 PM

Test Plan

Changelog

Review requests

Sanity check code

Risk assessment

Low

@smb2268 smb2268 self-assigned this Nov 30, 2023
@smb2268 smb2268 requested a review from a team as a code owner November 30, 2023 22:42
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #14076 (4df82c9) into edge (80022cb) will increase coverage by 0.00%.
Report is 8 commits behind head on edge.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14076   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files        2506     2506           
  Lines       71079    71142   +63     
  Branches     8906     8929   +23     
=======================================
+ Hits        50178    50223   +45     
- Misses      18722    18739   +17     
- Partials     2179     2180    +1     
Flag Coverage Δ
app 67.73% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/molecules/SimpleWizardBody/index.tsx 100.00% <ø> (ø)
app/src/organisms/GripperWizardFlows/Success.tsx 72.72% <ø> (ø)
...src/organisms/PipetteWizardFlows/DetachPipette.tsx 54.76% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LGTM after test fixes ✅

@smb2268 smb2268 merged commit 3fdaf68 into edge Dec 1, 2023
21 of 22 checks passed
@smb2268 smb2268 deleted the app_misc-design-fixes branch December 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants