fix(app): add final gripper animations to all flows #14072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14072 +/- ##
=======================================
Coverage 70.59% 70.60%
=======================================
Files 2506 2506
Lines 71079 71080 +1
Branches 8906 8907 +1
=======================================
+ Hits 50178 50183 +5
Misses 18722 18722
+ Partials 2179 2175 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
mjhuff
approved these changes
Nov 30, 2023
y3rsh
added a commit
that referenced
this pull request
Dec 1, 2023
* edge: (218 commits) fix(app): add final gripper animations to all flows (#14072) fix(engine): deck configuration pipette movement related errors (#14067) docs(api): add comment explaining post-drop slide (#14069) fix(app): only show 96 channel weight warning for 96 detach (#14068) fix(api, shared-data): avoid failures when dropping tip rack in trash chute (#14065) again allow liquid probe (#14064) refactor(shared-data): Delete unused Pydantic models for deck schema v4 (#14044) fix(api): resolve errors when dropping tip racks in trash chute (#14057) style(app,shared-data): Style deck waste chute submenu (#14055) refactor(protocol-designer): deck map renders wasteChuteStagingAreaFixture now (#14056) fix(shared-data): add pickUpOffset, dropOffset params to schema v7, v8 models (#14054) feat(app): introduce action needed text for module and deck section in ProtocolRunSetup (#14037) fix(protocol-designer): fix lint error in protocol-designer (#14053) fix(app): search for correct subsystem update for strung together flows (#14051) feat(engine): moveToAddressableArea implementation (#14039) fix(app): protect against null access of gripper data when fw update is ongoing (#14049) fix(protocol-designer): resolve duplicate slot option for waste chute in move labware (#14046) fix(app, shared-data): fix white screen during OT-2 calibration flows (#14048) feat(protocol-designer, step-generation): waste chute commands for dispense, air_gap, and blow_out (#13853) test(app): update remaining app tests to deck definition v4 (#14047) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-1931
Overview
Added animations from google sheet for gripper flows
Test Plan
Go through gripper detach, attach and calibrate flows and ensure animations are correct
Changelog
Replaced every animation file, a few were already correct so only 4 ended up having changes
Review requests
Review video, ensure animations match those in ticket - I ran into some errors during calibration so wasn't able to capture the last few pin animations
Gripper.animations.mov
Risk assessment
Low