-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, step-generation): wire up trash bin commands #14052
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14052 +/- ##
==========================================
+ Coverage 70.50% 70.58% +0.07%
==========================================
Files 2507 2503 -4
Lines 71147 71048 -99
Branches 8900 8906 +6
==========================================
- Hits 50163 50150 -13
+ Misses 18805 18721 -84
+ Partials 2179 2177 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bb6f4bb
to
44f43a9
Compare
a246fbe
to
682da25
Compare
!args.destLabware || | ||
(!invariantContext.labwareEntities[args.destLabware] && | ||
!invariantContext.additionalEquipmentEntities[args.destLabware]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should work right? For some reason it only works if you import a protocol that is missing the dest labware (rather than deleting the dest labware mid protocol). I also noticed labwareDoesNotExist
up above on line 99 has the same behavior. Maybe that can be investigated later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it depends where — step generation shorts circuits as soon as it sees an error so if there was another error before this in another form we wouldnt see anything
protocol-designer/src/components/StepEditForm/fields/StepFormDropdownField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/StepFormDropdownField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/FileSidebar/utils/getUnusedTrash.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/forms/MoveLiquidForm/SourceDestHeaders.tsx
Outdated
Show resolved
Hide resolved
const isWasteChute = | ||
additionalEquipmentEntities[wasteChuteOrLabwareId]?.name === 'wasteChute' | ||
const trashOrLabwareId = formData[addFieldNamePrefix('labware')] | ||
const isTrash = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could we call this disposalLocation
or something? cc @ncdiehl11 and @SyntaxColoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disposalLocation
makes sense to me. I wasn't sure the best word to encompass both trash bin and waste chute.
protocol-designer/src/steplist/formLevel/stepFormToArgs/moveLiquidFormToArgs.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
closes RAUT-866 RAUT-883, partially addresses RAUT-876
Overview
This PR wires up
dispense
,air_gap
,blow_out
into the trash bin as well as a bit of clean up followup work.Test Plan
Create a flex protocol and make sure the trash bin is added. Add some Transfer steps where you dispense and drop tip into the trash bin. see that nothing errors.
then export the protocol and examine the commands, you should see the
moveToAddressableArea
commands followed by the correctinPlace
command for the action. You can even import the protocol in the app and it should pass analysis!Then reimport the protocol back to PD and see that it imports correctly. (note: a timeline error might appear saying that the drop tip entity is missing, a fix for that will be in a follow up)
Changelog
wasteChuteCommandsUtil
andmovableTrashCommandsUtil
to be of return typeCurriedCommandCreator[]
since before, they were treated like compound commands but they are actually more like utils. So it is refactored to be similar toblowoutUtil
Review requests
see test plan
Risk assessment
low