-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 7.0.2 #13895
Merged
Merged
chore(release): 7.0.2 #13895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shlok Amin <[email protected]>
shlokamin
added
the
DO NOT MERGE
Indicates a PR should not be merged, even if there's a shiny green merge button available
label
Nov 1, 2023
shlokamin
changed the title
fix(app): improve robot update via usb (#13849)
chore(release): 7.0.2
Nov 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release #13895 +/- ##
========================================
Coverage 71.23% 71.23%
========================================
Files 2432 2432
Lines 68424 68419 -5
Branches 8047 8046 -1
========================================
+ Hits 48740 48741 +1
Misses 17797 17797
+ Partials 1887 1881 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closes RQA-1827 * fix(app): fix attachment flow firmware step filter Fixes the logic for determining whether or not the firmware step is necessary during an attachment flow. Because it's not possible to check whether an instrument or module needs a firmware update until it is attached, do not filter out the step entirely. Instead, if the instrument is known to have the latest firmware, gracefully proceed to the next step.
This prevents python from picking up versions of dependencies installed on the system, which will break offline analysis if the dependencies installed globally are old.
… 22 (#13907) Zip file robot updates ocassionally cause issues with retrying updates, especially on Windows. Remove the retry logic and file upload progress until sorted. Co-authored-by: Shlok Amin <[email protected]>
shlokamin
requested review from
ncdiehl11 and
sfoster1
and removed request for
a team
November 6, 2023 18:39
sfoster1
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
Indicates a PR should not be merged, even if there's a shiny green merge button available
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR tracks changes in the 7.0.2 hotfix