Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): replace RobotWorkSpace with BaseDeck for ProtocolSetup Liquids #13887

Closed

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 31, 2023

Overview

replacing RobotWorkSpace with BaseDeck for ProtocolSetup LiquidsMap view

close RAUT-821

Test Plan

Changelog

Review requests

Risk assessment

replacing RobotWorkSpace with BaseDeck for ProtocolSetup LiquidsMap view

close RAUT-821
@koji
Copy link
Contributor Author

koji commented Oct 31, 2023

  • update tests

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #13887 (54a46cd) into edge (71c168f) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13887      +/-   ##
==========================================
- Coverage   70.84%   70.77%   -0.07%     
==========================================
  Files        2504     1626     -878     
  Lines       70441    53957   -16484     
  Branches     8607     3795    -4812     
==========================================
- Hits        49902    38187   -11715     
+ Misses      18441    15105    -3336     
+ Partials     2098      665    -1433     
Flag Coverage Δ
app 43.57% <ø> (-25.31%) ⬇️
components 63.34% <ø> (ø)
labware-library 49.17% <ø> (ø)
protocol-designer 45.48% <ø> (ø)
step-generation 84.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 881 files with indirect coverage changes

@koji koji changed the title refactor(app): replace RobotWorkSpace with BaseDeck refactor(app): replace RobotWorkSpace with BaseDeck for ProtocolSetup Liquids Nov 3, 2023
@koji koji closed this Nov 3, 2023
@koji
Copy link
Contributor Author

koji commented Nov 3, 2023

This will be replaced by #13918

@koji koji deleted the app_refactor-replace-deck-map-with-BaseDeck-for-liquids branch November 29, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant