chore(monorepo): run jest on all frontend projects by default #13834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
So it turns out that jest's
watch
cli flag only works as expected (only rereuns tests that your code change affects using a dependency graph) if you don't provide specific test file paths.i.e.
yarn jest --watch
will only run tests that your src code change affects, whileyarn jest step-generation --watch
will rerun ALL step generation tests when a file change is made even if the file you modified is inside of theapp
directory.To fix this, rather than providing paths to all JS projects by default, we run
yarn
on everything unless file paths are provided.Good catch, @brenthagen!
Risk assessment
Low