Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): adjust cal dashboard to match figma #13765

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 11, 2023

Closes RQA-1217

Overview

Adjusts the size of the cal dashboard to fit the Figma designs.

Before

Screenshot 2023-10-11 at 5 30 23 PM

After

Screenshot 2023-10-11 at 5 24 14 PM

Test Plan

  • Open the cal dashboard and compare to figma.

Changelog

  • Calibration dashboard adjusted to match Figma designs.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner October 11, 2023 21:30
@mjhuff mjhuff requested review from jerader and a team and removed request for a team October 11, 2023 21:30
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #13765 (80952fd) into chore_release-7.0.1 (8a2ac3d) will decrease coverage by 0.12%.
Report is 6 commits behind head on chore_release-7.0.1.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.1   #13765      +/-   ##
=======================================================
- Coverage                71.25%   71.13%   -0.12%     
=======================================================
  Files                     2430     2430              
  Lines                    68426    68717     +291     
  Branches                  8042     8134      +92     
=======================================================
+ Hits                     48754    48882     +128     
- Misses                   17781    17923     +142     
- Partials                  1891     1912      +21     
Flag Coverage Δ
app 68.36% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/CalibrationTaskList/index.tsx 89.18% <ø> (ø)

... and 11 files with indirect coverage changes

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@mjhuff mjhuff merged commit e371ead into chore_release-7.0.1 Oct 12, 2023
28 checks passed
@mjhuff mjhuff deleted the app_adjust-cal-dashboard-css branch October 12, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants