feat(components): create base deck fixture components #13758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creates single slot, staging area, and waste chute components to be used by the existing BaseDeck component. BaseDeck now receives a deckConfig prop describing a robot deck configuration of fixures. the deck fixture components render SVGs corresponding to the fixture areas and slot clips provided by each fixture type closes RAUT-783
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13758 +/- ##
==========================================
- Coverage 70.90% 70.73% -0.17%
==========================================
Files 2456 2471 +15
Lines 69132 69433 +301
Branches 8284 8383 +99
==========================================
+ Hits 49016 49113 +97
- Misses 18159 18358 +199
- Partials 1957 1962 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
brenthagen
requested review from
a team and
b-cooper
and removed request for
a team and
b-cooper
jerader
approved these changes
Oct 11, 2023
| interface NotConfiguredModalProps { | ||
| onCloseClick: () => void | ||
| requiredFixture: FixtureLoadName | ||
| cutout: string | ||
| cutout: Cutout |
There was a problem hiding this comment.
oops thanks for fixing this!
Comment on lines
+32
to
+33
| // import { WasteChuteStagingAreaFixture } from './WasteChuteStagingAreaFixture' | ||
|
|
There was a problem hiding this comment.
wasteChuteStagingAreaFixture to be added later?
There was a problem hiding this comment.
yep, we'll have to add the waste chute staging area as a load name and option in various places also. that all should be a separate ticket i think
| import type { WizardTileProps } from './types' | ||
|
|
||
| const STAGING_AREA_SLOTS = ['A3', 'B3', 'C3', 'D3'] | ||
| const STAGING_AREA_SLOTS: Cutout[] = ['A3', 'B3', 'C3', 'D3'] |
koji
reviewed
Oct 11, 2023
| import type { ModalHeaderBaseProps } from '../../molecules/Modal/types' | ||
| import type { LegacyModalProps } from '../../molecules/LegacyModal' | ||
|
|
||
| interface AddDeckConfigurationModalProps { | ||
| fixtureLocation: string | ||
| fixtureLocation: Cutout |
koji
reviewed
Oct 11, 2023
| DeckConfiguration, | ||
| FLEX_ROBOT_TYPE, | ||
| LabwareDefinition2, | ||
| } from '@opentrons/shared-data' | ||
|
|
||
| import type { Meta, StoryObj } from '@storybook/react' |
There was a problem hiding this comment.
Can we move down import type?
koji
reviewed
Oct 11, 2023
| return ( | ||
| <path | ||
| fill="none" | ||
| stroke="#16212D" |
There was a problem hiding this comment.
nit
Suggested change
| stroke="#16212D" | |
| stroke={COLORS.darkBlackEnabled} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
creates single slot, staging area, waste chute, and waste chute staging area components to be used by the existing BaseDeck component. BaseDeck now receives a deckConfig prop describing a robot deck configuration of fixtures. the deck fixture components render SVGs corresponding to the fixture areas and slot clips provided by each fixture type. positioning and sizing subject to future adjustment.
updates various props in various places to use the
Cutouttype from shared-data forfixtureLocationwaste chute fixture foreign object representation is based on a design provided by Rob but not finalized
closes RAUT-783
Test Plan
Changelog
Review requests
run storybook, take a look
Risk assessment
low, BaseDeck unused in the app (for now)