fix(odd): pretend to be online all the time #13746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.1 #13746 +/- ##
=======================================================
- Coverage 71.24% 71.23% -0.01%
=======================================================
Files 2429 2430 +1
Lines 68430 68443 +13
Branches 8040 8040
=======================================================
+ Hits 48755 48758 +3
- Misses 17776 17786 +10
Partials 1899 1899
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shlokamin
approved these changes
Oct 10, 2023
| @@ -257,7 +261,7 @@ export const OnDeviceDisplayApp = (): JSX.Element => { | |||
|
|
|||
| // TODO (sb:6/12/23) Create a notification manager to set up preference and order of takeover modals | |||
| return ( | |||
| <ApiHostProvider hostname="localhost"> | |||
| <ApiHostProvider hostname="127.0.0.1"> | |||
There was a problem hiding this comment.
i guess this doesnt hurt but probably not necessary anymore
There was a problem hiding this comment.
yeah... i like having it though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, when the ODD starts and the robot boots while not connected to any network, some (some!) requests to localhost will fail. It's really strange. One thing that seems to help is pretending to be online by overriding the
navigator.onLinebrowser api to always return true.Testing
Closes RQA-1754