test(api): make test_filter_zero_duration_stepfilter a zero-duration step
#13736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro-duration steps
ncdiehl11
pushed a commit
that referenced
this pull request
Feb 1, 2024
…ero-duration steps (#13736) This test hasn't actually been testing anything for a while. This PR restores the original intention of the test, which is to ensure that move groups omit steps with a duration of 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This test hasn't actually been testing anything for a while. This PR restores the original intention of the test, which is to ensure that move groups omit steps with a duration of 0.
Test Plan
Ran the test and it worked
Changelog
test_filter_zero_duration_stepto filter out a step from a move groupReview requests
Risk assessment
None