fix(api): Flag pipette as not ready to aspirate after pushing out air #13728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13728 +/- ##
==========================================
- Coverage 70.95% 70.90% -0.06%
==========================================
Files 2451 1604 -847
Lines 68863 53275 -15588
Branches 8207 3634 -4573
==========================================
- Hits 48861 37773 -11088
+ Misses 18069 14916 -3153
+ Partials 1933 586 -1347
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
Oct 5, 2023
| @@ -1842,6 +1842,8 @@ async def dispense( | |||
| raise | |||
| else: | |||
| dispense_spec.instr.remove_current_volume(dispense_spec.volume) | |||
| if push_out or dispense_spec.instr.push_out_volume: | |||
There was a problem hiding this comment.
probably better for this to just be this since it's what actually controls things
Suggested change
| if push_out or dispense_spec.instr.push_out_volume: | |
| if dispense_spec.instr.push_out_volume: |
There was a problem hiding this comment.
if caller sets push_out=0 then the pipette is still ready-to-aspirate, so we need to either check this argument or we could specify what push-out volume was used within the dispense_spec and check that instead
andySigler
changed the title
…pushout. The previous value is always the tip's default value
ryanthecoder
approved these changes
Oct 13, 2023
y3rsh
added a commit
that referenced
this pull request
Oct 25, 2023
* edge: (77 commits) fix(app): update move gantry text in change pipette flow (#13712) fix(app): fix CI after release merge back (#13816) chore(hardware): add opentrons hardware package to ot 2 build (#13770) feat(protocol-designer): correct step count in create file wizard (#13807) feat(protocol-designer): error handling in create file wizard (#13804) fix(app): invalidate OT2 calibration queries when calibration flows complete (#13809) always jog (#13806) chore(app): point updates at dns not s3 (#13798) docs(api): updated Flex default flow rates (#13796) fix(api): Flag pipette as not ready to aspirate after pushing out air (#13728) fix(api, hardware): allow OT3Controller to disable tip motors (#13805) more blank trials; longer scale stabilize wait; submerge 2.5mm (#13788) fix(app): unload adapters after checking position of labware on adapter on heater shaker module (#13803) feat(app): wire up location conflict modal for ODD (#13797) feat(app): add Deck configuration page component (#13784) fix(robot-server): add default to robot serial (#13802) feat(protocol-designer, components): prep work for deck config in PD (#13775) feat(app, protocol-designer): plug in waste chute asset (#13800) fix(app): do not check mag block in calibration status (#13799) feat(protocol-designer): edit additional items staging area support (#13752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Set
ready_to_aspirate = Falseif a push-out volume is used during dispense. The plunger would then be below thebottomposition, and so would not be ready to aspirate.Test Plan
Changelog
Review requests
Risk assessment